Skip to content

Containerize CLI app#13

Closed
dreglad wants to merge 6 commits intophpcfdi:masterfrom
dreglad:containerized
Closed

Containerize CLI app#13
dreglad wants to merge 6 commits intophpcfdi:masterfrom
dreglad:containerized

Conversation

@dreglad
Copy link
Copy Markdown

@dreglad dreglad commented Apr 19, 2022

This PR containerizes this CLI tool

TODO:

  • Test the container image actualy works
  • Add a GitHub workflo to build and push a Docker image on releases
  • Update README

@dreglad dreglad changed the title Add basic Dockerfile Containerize CLI app Apr 19, 2022
@eclipxe13
Copy link
Copy Markdown
Member

Hi @dreglad.
Thanks for this PR.
Do you have the opportunity/willing to continue with this PR?

@dreglad dreglad marked this pull request as ready for review May 5, 2022 23:35
@dreglad
Copy link
Copy Markdown
Author

dreglad commented May 6, 2022

Hi @dreglad. Thanks for this PR. Do you have the opportunity/willing to continue with this PR?

@eclipxe13 Sure, I just pushed the remaning work and marked this PR as ready for review.

I included a GitHub workflow for continuously building and pushing the resulting Docker image into a public Docker registry. For simplicty, it assumes using the integrated gcr.io GitHub registry, but you might decide to publish into a different registry (e.g. Docker Hub) as well as you might want to set metadata image tags following your own conventions in case they differ from the semver pattern.

@eclipxe13
Copy link
Copy Markdown
Member

@dreglad Thanks for your commit. I had used the template as used in other PhpCfdi project.
You have the credit for this initiative since version 0.4.4.

@eclipxe13 eclipxe13 closed this Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants